-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WUnused: Fix for symbols with synthetic names and unused transparent inlines #17061
Merged
szymon-rd
merged 8 commits into
scala:main
from
szymon-rd:wunused-fix-trans-inline-and-synth-names
Mar 30, 2023
Merged
WUnused: Fix for symbols with synthetic names and unused transparent inlines #17061
szymon-rd
merged 8 commits into
scala:main
from
szymon-rd:wunused-fix-trans-inline-and-synth-names
Mar 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-rd
force-pushed
the
wunused-fix-trans-inline-and-synth-names
branch
4 times, most recently
from
March 8, 2023 13:52
5a46c7b
to
2230a07
Compare
szymon-rd
force-pushed
the
wunused-fix-trans-inline-and-synth-names
branch
3 times, most recently
from
March 13, 2023 14:21
a4683b9
to
f90da34
Compare
szymon-rd
force-pushed
the
wunused-fix-trans-inline-and-synth-names
branch
from
March 13, 2023 15:42
f90da34
to
97bdd0d
Compare
KacperFKorban
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just added one last nitpick.
szymon-rd
force-pushed
the
wunused-fix-trans-inline-and-synth-names
branch
from
March 28, 2023 16:06
59fb54d
to
56b484d
Compare
I think I will omit the symbols with |
Kordyjan
added
the
backport:accepted
This PR needs to be backported, once it's been backported replace this tag by "backport:done"
label
Apr 12, 2023
Kordyjan
added
backport:done
This PR was successfully backported.
and removed
backport:accepted
This PR needs to be backported, once it's been backported replace this tag by "backport:done"
labels
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16863